Skip to content

docs(config): colocate [[agents]] with users/groups in example config#20

Merged
tianzhou merged 4 commits into
mainfrom
docs/example-agents-colocate
Jun 25, 2026
Merged

docs(config): colocate [[agents]] with users/groups in example config#20
tianzhou merged 4 commits into
mainfrom
docs/example-agents-colocate

Conversation

@tianzhou

Copy link
Copy Markdown
Contributor

Summary

Reorders pgconsole.example.toml so the [[agents]] section sits alongside the other principals rather than at the end of the file:

Users → Groups → Agents → IAM Rules

This reads top-down: define the principals (users, groups, agents), then grant them access (IAM).

Changes

  • Moved the Agents section up from the end of the file to directly after the Groups subsection.
  • Relocated the pure-agent's inline [[iam]] example into the IAM Rules section (since IAM now follows Agents); the agent comment points to it with "(see below)".
  • Documented the agent:agentid member prefix in the IAM members reference line, alongside user:/group:/*.

Comments-only change to the example config — no code or behavior affected.

🤖 Generated with Claude Code

Move the Agents section to sit alongside the other principals (Users,
Groups) before IAM Rules, so the file reads define-principals then
grant-access. Relocate the pure-agent's [[iam]] example into the IAM
section and document the agent: member prefix there.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 25, 2026 03:54
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pgconsole Ready Ready Preview, Comment Jun 25, 2026 8:09am

@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown

Greptile Summary

This PR reorders pgconsole.example.toml so the [[agents]] section is collocated with the other principal definitions (users, groups) before the [[iam]] section, creating a logical top-down reading order: define principals first, then grant access.

  • Moved [[agents]] from the end of the file to directly after the [[groups]] block, and relocated the inline ci-bot [[iam]] example into the consolidated IAM Rules section at the bottom.
  • Added \"agent:agentid\" to the IAM Members reference comment alongside user:, group:, and *, making all valid principal prefixes explicit.
  • Updated cross-references: the agent comment says "(see below)" and the IAM example says "(see the Agents section above)", keeping the relationship between pure agents and their IAM grants discoverable.

Confidence Score: 5/5

Safe to merge — this is a comments-only reorganization of an example config file with no impact on runtime behavior.

The change touches only commented-out example content in a .toml template file. The section reorder is internally consistent: cross-references ("see below" / "see the Agents section above") correctly point to each other after the move, and the newly documented agent:agentid member prefix accurately reflects the existing agent authorization mechanism described in the rest of the file.

No files require special attention.

Important Files Changed

Filename Overview
pgconsole.example.toml Documentation-only reorganization: moves [[agents]] section before [[iam]], consolidates IAM examples, and adds agent:agentid to the members reference comment. Cross-references ("see below" / "see the Agents section above") are accurate after the reorder.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["General / Branding / AI Providers"] --> B["Labels"]
    B --> C["Connections"]
    C --> D["Authentication"]
    D --> E["Users + Groups"]
    E --> F["[[agents]] <- moved here"]
    F --> G["[[iam]] Rules\n(consolidated, references agents above)"]

    style F fill:#d1fae5,stroke:#059669
    style G fill:#dbeafe,stroke:#2563eb
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["General / Branding / AI Providers"] --> B["Labels"]
    B --> C["Connections"]
    C --> D["Authentication"]
    D --> E["Users + Groups"]
    E --> F["[[agents]] <- moved here"]
    F --> G["[[iam]] Rules\n(consolidated, references agents above)"]

    style F fill:#d1fae5,stroke:#059669
    style G fill:#dbeafe,stroke:#2563eb
Loading

Reviews (1): Last reviewed commit: "docs(config): colocate [[agents]] with u..." | Re-trigger Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the example configuration layout to place [[agents]] alongside other principals (users/groups) before the [[iam]] access-control rules, making the file read top-down: define principals → grant permissions.

Changes:

  • Reordered pgconsole.example.toml so [[agents]] appears before [[iam]].
  • Moved the pure-agent IAM rule example into the IAM section and added a “see below” pointer from the agent example.
  • Updated the IAM members reference line to include the agent: member type.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pgconsole.example.toml Outdated
Comment thread pgconsole.example.toml Outdated
Address PR review: user:/group: members are matched against the user's
email, so bare usernames never match. Use full emails (user:admin@example.com,
group members admin@example.com / developer@example.com) and clarify that "*"
applies to users only — pure agents match only explicit "agent:<id>" rules.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread pgconsole.example.toml Outdated
Address PR review: delegated agents (on_behalf_of) inherit their user's
IAM grant and so do match "*"/"user:"/"group:" rules via that user. Only
pure agents are limited to explicit "agent:<id>" rules.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread pgconsole.example.toml Outdated
Comment on lines +231 to +233
# Members: "user:<email>", "group:<id>", "agent:<id>", or "*" (all users; a pure
# agent matches only explicit "agent:<id>" rules, never "*"/"user:"/"group:",
# while a delegated agent inherits its user's matches)
Address PR review: label "*" as all human users to avoid implying it
matches agents (pure agents must be granted explicitly via agent:<id>).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@tianzhou tianzhou merged commit c0e8e3f into main Jun 25, 2026
3 checks passed
@tianzhou tianzhou deleted the docs/example-agents-colocate branch June 25, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants